Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove opcache_reset #1173

Merged
merged 4 commits into from
Nov 17, 2024
Merged

remove opcache_reset #1173

merged 4 commits into from
Nov 17, 2024

Conversation

withinboredom
Copy link
Collaborator

@withinboredom withinboredom commented Nov 16, 2024

fixes #1172 by checking for opcache_reset.

@AlliBalliBaba
Copy link
Collaborator

Executing opcache_reset is definitely a prerequisite for the watcher to work correctly. Otherwise the reloading logic will just be plain broken if opcache is enabled (which is the case on most php installations).
It would probably make more sense to just check if the function exists instead.

@withinboredom
Copy link
Collaborator Author

Executing opcache_reset is definitely a prerequisite for the watcher to work correctly.

Wouldn't that be part of the worker script though?

@AlliBalliBaba
Copy link
Collaborator

Wouldn't that be part of the worker script though?

Not necessarily, you would not want to call opcache_reset when the worker script restarts regularly, only when its restart was caused by the watcher.

@withinboredom
Copy link
Collaborator Author

Makes sense. I've updated this to conditionally check for opcache_reset.

@withinboredom withinboredom merged commit 0c123a2 into main Nov 17, 2024
46 checks passed
@withinboredom withinboredom deleted the remove/opcache-refresh branch November 17, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: opcache_reset not found
3 participants